Ticket #894 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Regression: nested XIncludes cause segfaults in PHP 5.2.5 and lower

Reported by: david Owned by: impl
Priority: normal Milestone: 1.0
Component: config Version: 1.0.0beta1
Severity: critical Keywords:
Cc: Patch attached: no

Description

See #621. The code is not there anymore.

We could consider adding a bool arg to AgaviXmlConfigParser::xinclude() to do that, or clean up by hand (it's called in a number of places)

Attachments

Change History

Changed 3 months ago by david

source:/tags/0.11.5RC1/src/config/AgaviXmlConfigParser.class.php#L175 and following did this

Changed 3 months ago by impl

  • status changed from new to closed
  • resolution set to fixed

(In [3165]) Fix #894: Regression: XIncludes in sandbox-tags result in PHP segfaults

Changed 3 months ago by david

  • summary changed from Regression: XIncludes in sandbox-tags result in PHP segfaults to Regression: nested XIncludes cause segfaults in PHP 5.2.5 and lower

Changed 3 months ago by david

(In [3166]) fixed changelog entry, my bad, refs #894

Changed 3 months ago by felix

(In [3191]) Merged revisions 3165-3166,3168,3171-3172,3187-3190 via svnmerge from http://svn.agavi.org/branches/1.0

........

r3165 | impl | 2008-10-24 22:57:54 +0200 (Fri, 24 Oct 2008) | 1 line

refs #894: Regression: XIncludes in sandbox-tags result in PHP segfaults

........

r3166 | david | 2008-10-24 23:03:29 +0200 (Fri, 24 Oct 2008) | 1 line

fixed changelog entry, my bad, refs #894

........

r3168 | impl | 2008-10-24 23:53:56 +0200 (Fri, 24 Oct 2008) | 1 line

refs #895: Regression: xml:base attributes left behind by XIncludes cause config validations to fail; fix comment formatting LOL DONGS

........

r3171 | david | 2008-10-25 14:31:36 +0200 (Sat, 25 Oct 2008) | 1 line

merge [3125:3170/branches/0.11]

........

r3172 | david | 2008-10-25 14:44:04 +0200 (Sat, 25 Oct 2008) | 1 line

converted build templates and sample app autoload.xml files to 1.0 configuration format, forgotten in [3140], refs #519

........

r3187 | impl | 2008-10-25 23:47:00 +0200 (Sat, 25 Oct 2008) | 1 line

If the templates directory is the Agavi templates directory when the project configuration system creates a new project, then use a variable reference to it instead of a hardcoded path (thanks Felix, Dominik)

........

r3188 | impl | 2008-10-26 01:29:06 +0200 (Sun, 26 Oct 2008) | 1 line

Update databases.xml to use 1.0-style handlers, refs #519, #462

........

r3189 | david | 2008-10-26 12:30:05 +0100 (Sun, 26 Oct 2008) | 1 line

ported sample and code tpl databases.xml files to new format, forgotten in [3188], refs #519

........

r3190 | felix | 2008-10-26 12:51:09 +0100 (Sun, 26 Oct 2008) | 3 lines

disabling modules works again and displays the disabled page instead of throwing an exception

........

Changed 3 months ago by felix

(In [3223]) Merged revisions 3124-3125,3138-3140,3145,3149,3151-3152,3165-3166,3168,3171-3172,3187-3190,3194,3200,3202,3205,3207,3213,3218 via svnmerge from http://svn.agavi.org/branches/1.0

........

r3124 | david | 2008-10-23 18:53:43 +0200 (Thu, 23 Oct 2008) | 1 line

-dev version info

........

r3125 | david | 2008-10-23 18:54:44 +0200 (Thu, 23 Oct 2008) | 1 line

merge [3092:3124/branches/0.11]

........

r3138 | impl | 2008-10-24 14:17:35 +0200 (Fri, 24 Oct 2008) | 1 line

Update naming for RNG datatypes, refs #519, #462

........

r3139 | impl | 2008-10-24 14:19:03 +0200 (Fri, 24 Oct 2008) | 1 line

Fix minor issues in XSL transformations, refs #519, #462

........

r3140 | impl | 2008-10-24 14:21:38 +0200 (Fri, 24 Oct 2008) | 1 line

Convert autoload.xml to 1.0 configuration format, refs #519, #462

........

r3145 | impl | 2008-10-24 14:28:31 +0200 (Fri, 24 Oct 2008) | 1 line

Fix typo and update unit tests

........

r3149 | impl | 2008-10-24 16:22:00 +0200 (Fri, 24 Oct 2008) | 1 line

Fix #891: Build system output is unreadable in Windows PowerShell?

........

r3151 | impl | 2008-10-24 16:24:24 +0200 (Fri, 24 Oct 2008) | 1 line

Remove stupid message that makes output ugly

........

r3152 | impl | 2008-10-24 17:10:41 +0200 (Fri, 24 Oct 2008) | 1 line

Support commas as well as spaces in project configuration system input lists

........

r3165 | impl | 2008-10-24 22:57:54 +0200 (Fri, 24 Oct 2008) | 1 line

Fix #894: Regression: XIncludes in sandbox-tags result in PHP segfaults

........

r3166 | david | 2008-10-24 23:03:29 +0200 (Fri, 24 Oct 2008) | 1 line

fixed changelog entry, my bad, refs #894

........

r3168 | impl | 2008-10-24 23:53:56 +0200 (Fri, 24 Oct 2008) | 1 line

Fix #895: Regression: xml:base attributes left behind by XIncludes cause config validations to fail; fix comment formatting LOL DONGS

........

r3171 | david | 2008-10-25 14:31:36 +0200 (Sat, 25 Oct 2008) | 1 line

merge [3125:3170/branches/0.11]

........

r3172 | david | 2008-10-25 14:44:04 +0200 (Sat, 25 Oct 2008) | 1 line

converted build templates and sample app autoload.xml files to 1.0 configuration format, forgotten in [3140], refs #519

........

r3187 | impl | 2008-10-25 23:47:00 +0200 (Sat, 25 Oct 2008) | 1 line

If the templates directory is the Agavi templates directory when the project configuration system creates a new project, then use a variable reference to it instead of a hardcoded path (thanks Felix, Dominik)

........

r3188 | impl | 2008-10-26 01:29:06 +0200 (Sun, 26 Oct 2008) | 1 line

Update databases.xml to use 1.0-style handlers, refs #519, #462

........

r3189 | david | 2008-10-26 12:30:05 +0100 (Sun, 26 Oct 2008) | 1 line

ported sample and code tpl databases.xml files to new format, forgotten in [3188], refs #519

........

r3190 | felix | 2008-10-26 12:51:09 +0100 (Sun, 26 Oct 2008) | 3 lines

disabling modules works again and displays the disabled page instead of throwing an exception

........

r3194 | felix | 2008-10-26 14:53:47 +0100 (Sun, 26 Oct 2008) | 8 lines

Merges the changes from branches/felix-testing-implementation, r3091 - r3192

  • adds the infrastructure for testing the framework itself
  • adds the first couple of TestCases?, mainly for the Routing

refs #380, #308

........

r3200 | impl | 2008-10-26 18:56:21 +0100 (Sun, 26 Oct 2008) | 1 line

Update routing.xml config handler to 1.0 format

........

r3202 | impl | 2008-10-26 19:06:38 +0100 (Sun, 26 Oct 2008) | 1 line

Fix hasChildren -> has checks in AgaviRoutingConfigHandler?

........

r3205 | felix | 2008-10-26 19:23:05 +0100 (Sun, 26 Oct 2008) | 9 lines

Merge from branches/felix-testing-implementation/ r3194 - r3204

  • More Tests for the routing
  • checks #444, #609
  • checks generation of the shortest possible url - this feature is currently broken

........

r3207 | impl | 2008-10-26 19:33:20 +0100 (Sun, 26 Oct 2008) | 1 line

Update routing.xml template and sample app

........

r3213 | david | 2008-10-26 20:46:57 +0100 (Sun, 26 Oct 2008) | 1 line

date fix

........

r3218 | felix | 2008-10-26 21:16:28 +0100 (Sun, 26 Oct 2008) | 3 lines

Merge from branches/felix-testing-implementation/ r3204 - r3216

........

Add/Change #894 (Regression: nested XIncludes cause segfaults in PHP 5.2.5 and lower)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.