Ticket #813 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

AgaviView::initialize() incorrectly assigns container's response to a property

Reported by: morkai@… Owned by: david
Priority: normal Milestone: 0.11.3
Component: view Version: 0.11.2
Severity: trivial Keywords: view response
Cc: Patch attached: no

Description

response property of AgaviView is set in the initialize() method, but it isn't specified in the class definition, so it's an anonymous property which won't show up in the code-assist feature of my editor ;)

Attachments

Change History

Changed 5 months ago by david

  • status changed from new to assigned
  • summary changed from $response property of AgaviView to AgaviView::initialize() incorrectly assigns container's response to a property
  • severity changed from normal to trivial
  • version changed from HEAD to 0.11.2
  • milestone set to 0.11.3

That is actually not intentional - AgaviView::getResponse(), a convenience shortcut method, is grabbing the response instance from the container, so there is no need to assign the response to a property, as well. Thanks for the heads-up, I'll remove the assignment from AgaviView::initialize().

Changed 5 months ago by david

  • status changed from assigned to closed
  • resolution set to fixed

(In [2675]) Fixed #813: AgaviView::initialize() incorrectly assigns container's response to a property

Add/Change #813 (AgaviView::initialize() incorrectly assigns container's response to a property)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.