Ticket #785 (closed task: fixed)

Opened 7 months ago

Last modified 12 days ago

Validation system needs to be able to tell two fields of same names, but from different sources, apart

Reported by: david Owned by: dominik
Priority: normal Milestone: 1.0
Component: validation Version: 0.11.1
Severity: major Keywords:
Cc: Patch attached: no

Description

While the validation system supports the concept of request data sources, it will internally store field results etc. without the associated source name.

As a consequence, it's not possible to validate a cookie and a field of the same names and then grab correct results, error messages etc.

Suggested solution: introduce a source property to validation incidents.

Attachments

Change History

Changed 7 months ago by david

  • summary changed from Two fields with same names from different sources cannot be told apart by the validation syste, to Two fields with same names from different sources cannot be told apart by the validation system

Changed 4 months ago by david

  • type changed from defect to task
  • milestone changed from 0.11.3 to 1.0

needs rearchitecturing; moving to 1.0

Changed 3 months ago by david

  • summary changed from Two fields with same names from different sources cannot be told apart by the validation system to Validation system needs to be able to tell to fields of same names, but from different sources, apart

Changed 3 months ago by david

  • summary changed from Validation system needs to be able to tell to fields of same names, but from different sources, apart to Validation system needs to be able to tell two fields of same names, but from different sources, apart

Changed 3 months ago by david

  • status changed from new to closed
  • resolution set to fixed

(In [3042]) Changelog update, closes #785

Changed 3 months ago by david

(In [3044]) release notes, refs #785

Changed 3 months ago by felix

(In [3045]) Merged revisions 3041-3044 via svnmerge from http://svn.agavi.org/branches/1.0

........

r3041 | david | 2008-10-16 19:50:17 +0200 (Thu, 16 Oct 2008) | 1 line

Ported AgaviValidatorConfigHandler? to XML config system, refs #519

........

r3042 | david | 2008-10-16 19:57:33 +0200 (Thu, 16 Oct 2008) | 1 line

Changelog update, closes #785

........

r3043 | david | 2008-10-16 19:59:20 +0200 (Thu, 16 Oct 2008) | 1 line

Another changelog entry, closes #786

........

r3044 | david | 2008-10-16 20:02:16 +0200 (Thu, 16 Oct 2008) | 1 line

release notes, refs #785

........

Changed 3 weeks ago by dominik

(In [3441]) fix getFailedFields calling a non existant method refs #785

Changed 3 weeks ago by david

there is a dedicated ticket for that last one, as that bug exist in 1.0.0beta4, 1.0.0beta5 and 1.0.0beta6, so we need a CHANGELOG entry for it so people know it's fixed and all... see #963

Changed 3 weeks ago by david

(In [3443]) missing CHANGELOG entry for [3441], closes #963 and refs #785

Changed 12 days ago by felix

(In [3448]) Merged revisions 3428,3430-3443,3445-3447 via svnmerge from https://svn.agavi.org/branches/1.0

........

r3428 | felix | 2008-12-10 23:34:19 +0100 (Wed, 10 Dec 2008) | 3 lines

adds some tests for the webrequestdataholder

........

r3430 | david | 2008-12-12 17:28:36 +0100 (Fri, 12 Dec 2008) | 1 line

merge [3420:3429/branches/0.11]

........

r3431 | felix | 2008-12-13 00:20:09 +0100 (Sat, 13 Dec 2008) | 4 lines

Adds some more tests for the WebRequestDataHolder?

-refs #955

........

r3432 | felix | 2008-12-14 15:23:52 +0100 (Sun, 14 Dec 2008) | 5 lines

adds some more tests for #955

  • covers all of the get/setCookie methods
  • covers all of the get/setParameter methods

........

r3433 | felix | 2008-12-14 18:37:51 +0100 (Sun, 14 Dec 2008) | 3 lines

adds some more testcases for the webrequestdataholder

........

r3434 | felix | 2008-12-14 18:47:03 +0100 (Sun, 14 Dec 2008) | 3 lines

splitting the AgaviWebRequestDataHolderTests? in separate files

........

r3435 | felix | 2008-12-14 22:42:44 +0100 (Sun, 14 Dec 2008) | 3 lines

  • allows inclusion/exclusion of suites via --include-suite / --exclude-suite

-refs #380

........

r3436 | felix | 2008-12-14 22:47:53 +0100 (Sun, 14 Dec 2008) | 3 lines

........

r3437 | felix | 2008-12-17 11:53:09 +0100 (Wed, 17 Dec 2008) | 4 lines

added two linebreaks to the end of the help-output in AgaviTesting?

refs #380

........

r3438 | felix | 2008-12-17 12:06:08 +0100 (Wed, 17 Dec 2008) | 6 lines

added and corrected some usage information

  • added info about environment
  • fixed cli call info

#refs 380

........

r3439 | felix | 2008-12-17 14:22:48 +0100 (Wed, 17 Dec 2008) | 4 lines

  • adds a testcase for the agavilocale
  • adds a test for AgaviLocale::getCalendarDaysWide()

-refs #308

........

r3440 | felix | 2008-12-17 14:24:00 +0100 (Wed, 17 Dec 2008) | 3 lines

code beauty, replace spaces by tabs for indenting

........

r3441 | dominik | 2008-12-18 14:44:53 +0100 (Thu, 18 Dec 2008) | 3 lines

fix getFailedFields calling a non existant method refs #785

........

r3442 | felix | 2008-12-19 22:03:19 +0100 (Fri, 19 Dec 2008) | 2 lines

testcase for #962 refs #962

........

r3443 | david | 2008-12-19 22:29:11 +0100 (Fri, 19 Dec 2008) | 1 line

missing CHANGELOG entry for [3441], closes #963 and refs #785

........

r3445 | impl | 2008-12-21 22:48:21 +0100 (Sun, 21 Dec 2008) | 1 line

merge [3430:3444/branches/0.11]

........

r3446 | david | 2008-12-22 19:11:16 +0100 (Mon, 22 Dec 2008) | 1 line

Fixed changelog entry for rephrased ticket, refs #929

........

r3447 | david | 2008-12-22 19:14:21 +0100 (Mon, 22 Dec 2008) | 1 line

Removed changelog entry for a fix for a bug which never was in a release, refs #929 and closes (again) #941

........

Add/Change #785 (Validation system needs to be able to tell two fields of same names, but from different sources, apart)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.