should not use "substr($str, 0, 1)" but "$str[0]"

[MugeSo]

In src/validator/AgaviDependencyManager.class.php, src/controller/AgaviController.class.php and src/routing/AgaviRouting.class.php, to retrive the first charactor of a string, substr function is used. However, in this case, []operator is better.

benchmark result:

[senna@vine senna]$ time php -r '$str="aaaaa"; for($i=0; $i < 1000000; $i++){ substr($str, 0, 1) == "a";}'

real    0m3.345s
user    0m3.320s
sys     0m0.020s
[senna@vine senna]$ time php -r '$str="aaaaa"; for($i=0; $i < 1000000; $i++){ $str[0] == "a";}'

real    0m2.012s
user    0m1.990s
sys     0m0.020s

[senna@vine senna]$ time php -r '$str="aaaaa"; for($i=0; $i < 1000000; $i++){ $str[0];}'

real    0m0.853s
user    0m0.850s
sys     0m0.010s
[senna@vine senna]$ time php -r '$str="aaaaa"; for($i=0; $i < 1000000; $i++){ substr($str, 0, 1);}'

real    0m2.585s
user    0m2.570s
sys     0m0.010s

[david]

good catch. thanks!

[MugeSo]

strpos($action, '/')===0 In FPF should change to $str[0]==='/' too.

[david]

I thought about this... the problem is that we'd get a notice if the string is empty. So we have to add a strlen() check, too. Which means we again have a method call, which probably eliminates the performance advantage, and most importantly: makes the code less readable. Not worth it in the end, I think. I'm closing this as wontfix for now; feel free to re-open the ticket if you believe I'm wrong, or add comments, or discuss it on IRC/dev mailing list :)

[MugeSo]

So we have to add a strlen() check, too.

i use isset() and benchmark again :)

[senna@vine senna]$ time php -r '$str="abaed"; $token="a"; for($i=0; $i < 1000000; $i++){ isset($str[0]) && $str[0] === $token;}'

real    0m1.959s
user    0m1.940s
sys     0m0.020s
[senna@vine senna]$ time php -r '$str=5; $token="a"; for($i=0; $i < 1000000; $i++){ isset($str[0]) && $str[0] === $token;}'

real    0m0.969s
user    0m0.950s
sys     0m0.020s

but, this code accepts $str=array($token).