Ticket #608 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

Caching leaves room for potential race condition

Reported by: Felix Gilcher <mailing_lists@…> Owned by: david
Priority: normal Milestone: 0.11
Component: filter Version: HEAD
Severity: normal Keywords: AgaviExecutionFilter Cache Race Condition
Cc: Patch attached:

Description

Currently, the AgaviExecution? filter calls checkCache() to see wether an action has been cached and then readCache() to retrieve the cached values. However, no checking is done on the return value of readCache() so that in multithreaded environements a clearCache() call from another thread might happen inbetween the check and the read, leading to an error.

Solution: check the result of the readCache operation and act accordingly (if fail, treat action as not cached).

Attachments

Change History

Changed 13 months ago by david

  • milestone changed from 0.11 to 1.0

Should be fixed as part of the 1.0 storage rewrite

Changed 13 months ago by david

  • status changed from new to assigned
  • milestone changed from 1.0 to 0.11

Changed 13 months ago by david

  • status changed from assigned to closed
  • resolution set to fixed

(In [2169]) more graceful handling of potential race conditions on cache read, closes #608

Changed 13 months ago by david

(In [2170]) error suppression, otherwise [2169] would be pretty pointless, refs #608

Add/Change #608 (Caching leaves room for potential race condition)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.