Changeset 2913

Timestamp:

09/19/08 19:16:47 (4 months ago)

Author:

david

Message:

tests for sample app, they work again now after [2904] which merged [2903] (and [2912] / [2911]). this is good fun. refs #859, #861 and #380

Location:

branches/1.0/samples/test/tests

Files:

• fragment/SearchEngineSpamActionTest.php (modified) (3 diffs)
• unit/PriceFinderModelTest.php (modified) (2 diffs)

branches/1.0/samples/test/tests/fragment/SearchEngineSpamActionTest.php

@@ -3 +3 @@
 class SearchEngineSpamActionTest extends AgaviActionTestCase
 {
+  protected static $products = array(
+    array(
+      'id'    => 8172401,
+      'name'  => 'brains',
+      'price' => 0.89,
+    ),
+    array(
+      'id'    => 917246,
+      'name'  => 'chainsaws',
+      'price' => 129.99,
+    ),
+    array(
+      'id'    => 7856122,
+      'name'  => 'mad coding skills',
+      'price' => 14599,
+    ),
+    array(
+      'id'    => 123456,
+      'name'  => 'nonsense',
+      'price' => 3.14,
+    ),
+    array(
+      'id'    => 3165463,
+      'name'  => 'viagra',
+      'price' => 14.69,
+    ),
+  );
   
   public function __construct($name = NULL, array $data = array(), $dataName = '')
@@ -12 +39 @@
   
   /**
-   * @dataProvider products
+   * @dataProvider successViewValidProductsData
    */
-  public function testSuccessViewValidProducts($productName)
+  public function testSuccessViewValidProducts($parameters, $price)
   {
     $this->setRequestMethod('read');
-    $this->setArguments($this->createRequestDataHolder(array(AgaviWebRequestDataHolder::SOURCE_PARAMETERS => array('name' => $productName))));
-    $this->performValidation();
-    //$this->assertValidatesArgument('name', 'AgaviStringValidator', array('min' => 5));
+    $this->setArguments($this->createRequestDataHolder(array(AgaviWebRequestDataHolder::SOURCE_PARAMETERS => $parameters)));
     $this->runAction();
     $this->assertViewNameEquals('Success');
     $this->assertViewModuleNameEquals('Default');
     $this->assertContainerAttributeExists('product_price');
-    $this->assertContainerAttributeEquals($productName, 'product_name');
-    
+    $this->assertContainerAttributeEquals($price, 'product_price');
   }
   
-  public function testErrorViewInvalidProduct()
+  public function successViewValidProductsData()
+  {
+    $retval = array();
+    foreach(self::$products as $product) {
+      $retval['id only: ' . $product['id']] = array(array('id' => $product['id']), $product['price']);
+    }
+    foreach(self::$products as $product) {
+      $retval['id+name: ' . $product['id'] . '/' . $product['name']] = array(array('id' => $product['id'], 'name' => $product['name']), $product['price']);
+    }
+    return $retval;
+  }
+  
+  /**
+   * @dataProvider errorViewInvalidProductsData
+   */
+  public function testErrorViewInvalidProducts($parameters)
   {
     $this->setRequestMethod('read');
-    $this->setArguments($this->createRequestDataHolder(array(AgaviWebRequestDataHolder::SOURCE_PARAMETERS => array('name' => 'nonexistant product'))));
+    $this->setArguments($this->createRequestDataHolder(array(AgaviWebRequestDataHolder::SOURCE_PARAMETERS => $parameters)));
     $this->runAction();
     $this->assertViewNameEquals('Error');
     $this->assertViewModuleNameEquals('Default');
+  }
+  
+  public function errorViewInvalidProductsData()
+  {
+    return array(
+      'only product name given' => array(array('name' => 'nonsense')),
+      'invalid product id given' => array(array('id' => 81236123)),
+      'negative product id given' => array(array('id' => -1)),
+      'id and name given, id invalid' => array(array('id' => 123457, 'name' => 'nonsense')),
+      'id and name given, name invalid' => array(array('id' => 123456, 'name' => 'nonsenseZOMG')),
+      'id and name given, both invalid' => array(array('id' => -1, 'name' => 'nonsenseZOMG')),
+    );
   }
   
@@ -59 +110 @@
   public function products()
   {
+    
     return array(
       'brains'    => array('brains'),

branches/1.0/samples/test/tests/unit/PriceFinderModelTest.php

@@ -4 +4 @@
 class PriceFinderModelTest extends AgaviUnitTestCase
 {
+  protected static $products = array(
+    array(
+      'id'    => 8172401,
+      'name'  => 'brains',
+      'price' => 0.89,
+    ),
+    array(
+      'id'    => 917246,
+      'name'  => 'chainsaws',
+      'price' => 129.99,
+    ),
+    array(
+      'id'    => 7856122,
+      'name'  => 'mad coding skills',
+      'price' => 14599,
+    ),
+    array(
+      'id'    => 123456,
+      'name'  => 'nonsense',
+      'price' => 3.14,
+    ),
+    array(
+      'id'    => 3165463,
+      'name'  => 'viagra',
+      'price' => 14.69,
+    ),
+  );
+  
   /**
-   * @dataProvider productPrices
+   * @dataProvider productNamePrices
    */
-  public function testValidProductPrices($productName, $price)
+  public function testValidProductPricesByName($productName, $price)
   {
     $finder = $this->getContext()->getModel('PriceFinder', 'Default');
@@ -13 +41 @@
   }
   
-  public function productPrices()
+  public function productNamePrices()
   {
-    return array(
-      'brains'    => array('brains', 0.89),
-      'chainsaws' => array('chainsaws', 129.99),
-      'coding'    => array('mad coding skills', 14599),
-      'nonsense'  => array('nonsense', 3.14),
-      'viagra'    => array('viagra', 14.69),
-    );
+    $retval = array();
+    foreach(self::$products as $product) {
+      $retval[$product['name']] = array(
+        $product['name'],
+        $product['price'],
+      );
+    }
+    return $retval;
   }
   
-  public function testPriceNullForUnknownProduct()
+  /**
+   * @dataProvider productIdPrices
+   */
+  public function testValidProductPricesById($productId, $price)
+  {
+    $finder = $this->getContext()->getModel('PriceFinder', 'Default');
+    $this->assertEquals($price, $finder->getPriceByProductId($productId));
+  }
+  
+  public function productIdPrices()
+  {
+    $retval = array();
+    foreach(self::$products as $product) {
+      $retval[$product['name']] = array(
+        $product['id'],
+        $product['price'],
+      );
+    }
+    return $retval;
+  }
+  
+  /**
+   * @dataProvider productInfoPrices
+   */
+  public function testValidProductPricesByInfo($productId, $productName, $price)
+  {
+    $finder = $this->getContext()->getModel('PriceFinder', 'Default');
+    $this->assertEquals($price, $finder->getPriceByProductInfo($productId, $productName));
+  }
+  
+  public function productInfoPrices()
+  {
+    $retval = array();
+    foreach(self::$products as $product) {
+      $retval[$product['name']] = array(
+        $product['id'],
+        $product['name'],
+        $product['price'],
+      );
+    }
+    return $retval;
+  }
+  
+  public function testPriceNullForUnknownProductName()
   {
     $this->assertNull($this->getContext()->getModel('PriceFinder', 'Default')->getPriceByProductName('unknown product'));
+  }
+  
+  public function testPriceNullForUnknownProductId()
+  {
+    $this->assertNull($this->getContext()->getModel('PriceFinder', 'Default')->getPriceByProductId(-1));
+  }
+  
+  public function testPriceNullForUnknownProductInfo()
+  {
+    $this->assertNull($this->getContext()->getModel('PriceFinder', 'Default')->getPriceByProductInfo(-1, 'unknown product'));
+  }
+  
+  public function testPriceNullForPartiallyValidProductInfo()
+  {
+    $this->assertNull($this->getContext()->getModel('PriceFinder', 'Default')->getPriceByProductInfo(123456, 'nonsenseZOMG'));
+    $this->assertNull($this->getContext()->getModel('PriceFinder', 'Default')->getPriceByProductInfo(1234567, 'nonsense'));
   }
 }